Conversation
- Added Conflux mainnet and testnet configurations to the indexer. - Updated XRP indexer to handle new transaction types including clawback and claimable balance operations. - Enhanced Stellar indexer to support claimable balance operations and improved transaction metadata handling. - Removed outdated test files for Stellar and XRP indexers.
- Introduced a new `DirectionalNormalizer` interface to handle transaction normalization based on direction for both Stellar and XRP indexers. - Added `normalizeDirectionalMetadata` function to process transaction metadata according to the specified direction. - Updated `StellarIndexer` and `XRPIndexer` to implement the normalization logic. - Enhanced tests to validate the correct handling of source-side routing for path payments in both Stellar and XRP transactions. - Added new test cases to ensure proper functionality of the directional normalization feature.
- Added entries for IDE and cache directories to .gitignore. - Refactored Stellar and XRP indexers to directly assign memo and destination tag fields instead of using metadata methods. - Updated related tests to reflect changes in transaction metadata handling.
- Updated tests and implementation to use the new MemoType type for memoType fields in Stellar transactions. - Replaced string comparisons with MemoType constants to ensure consistency and type safety across the codebase. - Adjusted related tests to reflect the changes in memoType assertions.
anhthii
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds XRP and Stellar indexing support and aligns emitted transfer events with wallet-balance consumers.
For Stellar claimable balances, the event contract is intentionally kept
from/to-only for downstream services:create_claimable_balanceemits only as a source-side debit whentwo_way_indexingis enabledclaim_claimable_balanceemits only as a claimant-side creditclawback_claimable_balanceclears local claimable-balance state but does not emit a wallet balance eventChanges
claim_claimable_balancewhen local claimable-balance state is missingfrom/toaddresses onlyStellar Claimable Balance Semantics
This PR treats claimable balance operations based on actual wallet balance impact instead of synthetic object addresses:
create_claimable_balancefrom=<source>,to=""claim_claimable_balancefrom="",to=<claimant>clawback_claimable_balanceThis avoids double-counting claimant deposits and avoids exposing synthetic
stellar:claimable_balance:<id>addresses to downstream services.Testing
go test ./internal/indexer -shortgo test ./internal/worker